D22393: remove UnhandledErrorDialog

Harald Sitter noreply at phabricator.kde.org
Thu Jul 11 11:05:01 BST 2019


sitter created this revision.
sitter added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the dialog was actually broken through at least all of plasma5 :/
  
  this is no longer necessary. it was used for when random unexpected HTML
  would get returned. there is no longer unexpected html:
  
  - the api always returns json blobs
  - should the api crap out we'll get protocol errors (HTTP 500 or some such) which is also forced into a serialized form and raised as a ProtocolException to be handled like errors from the API directly
  
  we always get one "standardized" error message and never an
  extended html to display.

TEST PLAN
  builds

REPOSITORY
  R871 DrKonqi

BRANCH
  remove-unhandlederrordialog

REVISION DETAIL
  https://phabricator.kde.org/D22393

AFFECTED FILES
  src/bugzillaintegration/bugzillalib.h
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla.h
  src/bugzillaintegration/reportinterface.h

To: sitter, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190711/20536495/attachment.html>


More information about the Plasma-devel mailing list