D18920: Fix PCI module

Christoph Feck noreply at phabricator.kde.org
Wed Jul 10 19:12:15 BST 2019


cfeck added inline comments.

INLINE COMMENTS

> kpci_private.h:48
>  
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are

structure or structures?

> kpci_private.h:49
> +/* Following structurs MUST BE packed, otherwise variables will be mapped to
> +   wrong places. Q_PACKED macro seems not work very well. `#pragma pack` are
> +   more widely adopted, and should be ignored if not supported.

seems to

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D18920

To: konradr, #plasma, cfeck
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190710/4f3791a7/attachment.html>


More information about the Plasma-devel mailing list