D22322: Store crash report automatically if shutting down

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  some style annoyances. fix it then ship it 👍

INLINE COMMENTS

> drkonqi.cpp:254
> +
> +    QObject::connect(btGenerator, &BacktraceGenerator::done, &saveReportAndQuit);
> +    QObject::connect(btGenerator, &BacktraceGenerator::someError, &saveReportAndQuit);

I think three-argument connects are considered bad form, you may want to add a scoping object for the slot.

> main.cpp:37
>  #include <QDebug>
> +#include <QTemporaryFile>
> +#include <QFile>

these two includes look unused

> main.cpp:56
>  #include "statusnotifier.h"
> +#include "debuggermanager.h"
> +#include "backtracegenerator.h"

these 2 includes look unused

REPOSITORY
  R871 DrKonqi

BRANCH
  storeGuiless

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava, sitter, davidedmundson
Cc: sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190709/3ee8b0a5/attachment-0001.html>