D22316: Avoid garbling the sound if the volume slider is moved fast

kezi noreply at phabricator.kde.org
Mon Jul 8 14:19:48 BST 2019


kezik updated this revision to Diff 61337.
kezik added a comment.


  Thanks @davidedmundson for the feedback, 
  I fixed what you suggested, but thinking about this again, the 50ms timer fixed the audio garbling but the sounds felt "too frequent", increasing the timer gave the same exact result as disabling the function altogether, so here's that.
  It wasn't worth the extra complexity of the timer

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22316?vs=61302&id=61337

REVISION DETAIL
  https://phabricator.kde.org/D22316

AFFECTED FILES
  src/qml/volumefeedback.cpp

To: kezik, #vdg
Cc: davidedmundson, plasma-devel, kezik, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190708/a6d026df/attachment-0001.html>


More information about the Plasma-devel mailing list