D22322: Store crash report automatically if shutting down

[David Edmundson]

davidedmundson added a comment.


  Concept: +1
  
  One question, when do we create a DBusInterfaceLauncher  instance.  Is it in time here?
  
  Without this startkde won't know there's a drkonqi it should be waiting for and then whether you finish saving or not becomes racey.

INLINE COMMENTS

> drkonqi.cpp:216
> +    {
> +        QString defname = QDir::homePath() + QDir::separator() + getSuggestedKCrashFilename(DrKonqi::crashedApplication());
> +

Can we avoid littering the home directory. Somewhere in .cache might make sense, as if it gets lost it's not too important.

I've also been told it's more correct to use "/" instead of QDir::separator.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22322

To: tcanabrava
Cc: davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190708/8c298137/attachment.html>