D22312: [DeviceNotifications] Keep last message for each device

Stefan BrĂ¼ns noreply at phabricator.kde.org
Sun Jul 7 19:02:36 BST 2019


bruns created this revision.
bruns added reviewers: Plasma, broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.

REVISION SUMMARY
  Ejecting e.g. a USB stick removes it from the bus (bus power is removed),
  but the last notification should be kept, otherwise a message like
  "The device can be savely removed" immediately disappears.
  
  Unfortunately it is almost impossible to tell when a device has been
  physically removed (only indirectly, when a new device is plugged into
  the same port), so allow some small leakage - in case the same device is
  later replugged, no leakage happens.

TEST PLAN
  Card reader:
  1.insert medium, mount, unmount
  
    -> message "Device can be savely removed" is shown in device notifier
  
  for 5 seconds
  
  2. eject medium, reinsert -> device appears without message and with default label

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cleanup_devicenotifier

REVISION DETAIL
  https://phabricator.kde.org/D22312

AFFECTED FILES
  dataengines/devicenotifications/ksolidnotify.cpp

To: bruns, #plasma, broulik, ngraham
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190707/40f2954a/attachment.html>


More information about the Plasma-devel mailing list