D22233: Code Simplification / Readability Changes

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> backtraceratingwidget.cpp:48
>  
> -    p.drawPixmap(QPoint(30, 1) , m_star1 ? m_starPixmap : m_disabledStarPixmap);
> -    p.drawPixmap(QPoint(55, 1) , m_star2 ? m_starPixmap : m_disabledStarPixmap);
> -    p.drawPixmap(QPoint(80, 1) , m_star3 ? m_starPixmap : m_disabledStarPixmap);
> +    p.drawPixmap(QPoint(30, 1) , m_usefullness >= BacktraceParser::ProbablyUseless ? m_starPixmap : m_disabledStarPixmap);
> +    p.drawPixmap(QPoint(55, 1) , m_usefullness >= BacktraceParser::MayBeUseful ? m_starPixmap : m_disabledStarPixmap);

Can we switch over m_usefullness instead? Using enums as integers gets me all worked up.

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D22233

To: tcanabrava
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190703/00456b97/attachment.html>