D22229: Ignore Next/Previous call if CanGoNext/CanGoPrevious are false
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Jul 3 08:21:03 BST 2019
broulik created this revision.
broulik added reviewers: Plasma, fvogt.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Spec says "If is false, attempting to call this method should have no effect."
TEST PLAN
No longer get an event in the content-script when calling Previous/Next if we can't go previous/next.
Still works if website sets a `previoustrack` or `nexttrack` callback
REPOSITORY
R856 Plasma Browser Integration
REVISION DETAIL
https://phabricator.kde.org/D22229
AFFECTED FILES
host/mprisplugin.cpp
To: broulik, #plasma, fvogt
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190703/1bf5848e/attachment.html>
More information about the Plasma-devel
mailing list