D22191: Implement syncing of theme preferences between SDDM and Plasma

Filip Fila noreply at phabricator.kde.org
Tue Jul 2 13:25:25 BST 2019


filipf added inline comments.

INLINE COMMENTS

> davidedmundson wrote in advanceconfig.cpp:179
> If it's empty, you print a message, which is fine, but then we still add an empty entry to our map, and still try to copy the file?

Should I just bring back the code that only does the copy operation if the entry is not empty or would it also be good to not even add the entry to the map if there is no file/folder?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190702/4834bb50/attachment-0001.html>


More information about the Plasma-devel mailing list