D22191: Implement syncing of theme preferences between SDDM and Plasma

Filip Fila noreply at phabricator.kde.org
Mon Jul 1 16:27:37 BST 2019


filipf planned changes to this revision.
filipf added a comment.


  Definitely have to fix the hardcoding.
  
  The whole .ui file also needs to be redone from scratch since there's leftovers from tinkering with it in QtDesigner.

INLINE COMMENTS

> davidedmundson wrote in sddmauthhelper.cpp:118
> What's the point of this argument when you hardcode/evaluate it so much in this file.

Initially it was supposed to be a check that the Reset button was pressed (because that's when the argument would get emitted), but I'll check if it can be removed now.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22191

To: filipf, #plasma, ngraham, davidedmundson, #vdg
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190701/5254a704/attachment-0001.html>


More information about the Plasma-devel mailing list