D18607: Add a popup search bar to the plasma-nm applet

[Valerio Pilo]

vpilo added a comment.


  Here's my latest change, not submitted yet.
  
  | F6576947: short.png <https://phabricator.kde.org/F6576947> | F6576946: search.png <https://phabricator.kde.org/F6576946> | F6576945: long.png <https://phabricator.kde.org/F6576945> |
  |
  
  The differences are that I moved the bar to the top, made the label into a placeholder text, and added a bit of margin on the textfield sides.
  
  In D18607#402431 <https://phabricator.kde.org/D18607#402431>, @jgrulich wrote:
  
  > > Putting the search bar in the toolbar on top is an interesting idea. There's definitely room on mine. However it does start to feel a bit cramped. +1 for the idea of a search field though.
  >
  > My opinion is: I don't want the search bar to take any additional vertical space by default, not even when there is many connections, because I don't need usually to scroll down to find the connection I need. On the other hand I get it might be useful for someone else. What about showing the search bar once users start typing?
  
  
  If you usually don't need to scroll down to find a connection you need, then you won't see the search bar.
  
  As you can see:
  
  - When the list of connections is short:
    - If the user starts typing, then it shows automatically.
    - When the field is emptied, then it hides.
  - When the list of connections is long enough to already need a scrollbar:
    - The field is always shown, and highlighted.
    - You just lose one entry of vertical space that you have to scroll through anyway.
  
  In D18607#402444 <https://phabricator.kde.org/D18607#402444>, @ngraham wrote:
  
  > In D18607#402435 <https://phabricator.kde.org/D18607#402435>, @jgrulich wrote:
  >
  > > Alternatively we can show a small input box just saying "Search ..."  and clicking into it to start typing it would hide all the switches in the toolbar (wifi, wwan, airplane) and expand across the whole toolbar?
  >
  >
  > That's not a bad idea! And then when the user clicks on the "clear text" on the right side of the search field, it would collapse to its prior size.
  
  
  I think my approach is less visually obtrusive, and you can still use everything else in the widget while the search field is active.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18607

To: vpilo, #vdg, #plasma
Cc: jgrulich, ngraham, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190130/aae6ca62/attachment.html>