D18597: Fix combobox initial sizing
David Edmundson
noreply at phabricator.kde.org
Tue Jan 29 16:29:42 GMT 2019
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.
REVISION SUMMARY
We have a listview in a popup. The popup is resized to the listview
content height.
Because the popup starts out at size 0 the listview thinks it's too
small to show anything.
So it doesn't load any delegates.
As it has no delegates it can't guess the contentHeight.
contentHeight is a guess based on count * (currentHeight
/ currentlyLoadedDelegates)
That means the popup doesn't resize properly.
Ultimately it does end up showing a two entries, but it doesn't
re-evaluate the contentHeight properly to resize the popup correctly.
Forcing it to load one delegate is enough to break that cycle.
BUG: 403736
TEST PLAN
Opened popup in cursortheme and fonts
Worked correctly
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D18597
AFFECTED FILES
org.kde.desktop/ComboBox.qml
To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190129/1b58e30a/attachment.html>
More information about the Plasma-devel
mailing list