D18438: [Task Manager] When closing apps, resize only when mouse is out.

Eike Hein noreply at phabricator.kde.org
Fri Jan 25 10:23:21 GMT 2019


hein added a comment.


  I think it needs to be made a bit more robust still. For one it's not called `requestClose()` without reason: Not all windows are closable / will be closed upon this request. It might also race with a different window closing going on in parallel. `taskClosedWithMouseMiddleButton` needs to be invalidated on exit, and the middle-click close and `onItemRemoved` probably need to compare persistent model indexes or window ids (easier) to check it's the same.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190125/8cd3659b/attachment.html>


More information about the Plasma-devel mailing list