D12278: [Colors KCM] Port to new design

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> colors.cpp:228
> +
> +void KCMColors::installSchemeFromFile(const QUrl &url)
> +{

what would happen if this is called twice before the file_copy completes?

> main.qml:71
> +
> +    view.remove: Transition {
> +        ParallelAnimation {

It seems these should be standard across all GridView KCMs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190124/980a6ea8/attachment-0001.html>