D18489: warnings--

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KAboutData::setProgramIconName isn't used in the AboutData dialog box,
  instead the generic QApplication icon name is used.
  
  Therefore there's little point setting it. It was also used by classic
  mode to create an icon in the config page that it has, but we can do
  that directly.

TEST PLAN
  Compiles
  Looked at module about data
  Looked at settings page

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18489

AFFECTED FILES
  classic/CategoryList.cpp
  classic/ClassicMode.cpp
  core/ModuleView.cpp
  icons/IconMode.cpp
  sidebar/SidebarDelegate.cpp
  sidebar/SidebarMode.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190124/80feca79/attachment.html>