D18481: [applets/appmenu] Show placeholder when configuring and empty

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Jan 23 19:24:26 GMT 2019


broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:104
> +        PlasmaComponents.ToolButton {
> +            id: noMenuPlaceholder
> +            visible: buttonRepeater.count == 0

Unused id

> main.qml:106
> +            visible: buttonRepeater.count == 0
> +            text: i18n("Application Menu")
> +            Layout.preferredWidth: minimumWidth

I think you could just use `plasmoid.title` here

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18481

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190123/d844c7a7/attachment.html>


More information about the Plasma-devel mailing list