D15304: [WIP] [KCM] Port to QQC2

[David Rosca]

drosca requested changes to this revision.
drosca added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> Advanced.qml:32
>  
> +    Layout.fillWidth: true
> +    Layout.fillHeight: true

This should be set where this item is used (main.qml).

> Advanced.qml:40
>      ColumnLayout {
> -        Component.onCompleted: {
> -            // Normal binding causes binding loops
> -            width = Qt.binding(function() {
> -                return scrollView.viewport.width;
> -            });
> -        }
> +        width: scrollView.width
>  

`anchors.fill: parent` ?

> main.qml:47
> +            // https://bugs.kde.org/show_bug.cgi?id=394296
> +            Layout.leftMargin: 1
> +

I don't really like those hardcodes, are you sure it won't break when using different QWidget style?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15304

To: ngraham, #plasma, drosca
Cc: huftis, nicolasfella, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190122/8e22957b/attachment-0001.html>