D18437: Improve saving an invalid certificate fingerprint to avoid the need to accept it every time

[Enrique Melendez]

enriquem created this revision.
enriquem added a reviewer: jgrulich.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
enriquem requested review of this revision.

REVISION SUMMARY
  The way an invalid certificate fingerprint is saved in the [vpn-secrets] section does not work. It is unconditionally saved with a key certificate:[host]:[port] when the users accepts the invalid certificate, and is never retrieved so that the user has to accept the certificate again next time.
  
  So, I have changed that behavior to save the fingerprint with a different key, and give the user the chance to accept the fingerprint only for the current connection, to accept it forever, and to delete it from the config file. And make it work properly, that is, once accepted, the user is never asked again.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D18437

AFFECTED FILES
  vpn/openconnect/CMakeLists.txt
  vpn/openconnect/nm-openconnect-service.h
  vpn/openconnect/openconnectadvanced.ui
  vpn/openconnect/openconnectauth.cpp
  vpn/openconnect/openconnectprop.ui
  vpn/openconnect/openconnectwidget.cpp
  vpn/openconnect/openconnectwidget.h

To: enriquem, jgrulich
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190121/484cd2d4/attachment.html>