D18430: [DesktopView] Don't set a window icon

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Jan 21 16:29:58 GMT 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The desktop view isn't visible in the task bar, tabbox, and neither does it have a window decoration.

TEST PLAN
  Saves some RAM and startup time.
  
    QWindow::setIcon` in this case was 1.63% on startup, mostly caused by icon theme setup stuff, so the impact isn't as noticeable overall.
    Verified in xprop that the icon was gone.
    Plasma popups that show up in tabbox are unaffected and still have an icon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18430

AFFECTED FILES
  shell/desktopview.cpp

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190121/734bcbc0/attachment-0001.html>


More information about the Plasma-devel mailing list