D18322: [Look and Feel and KSplash KCM] Set sourceSize for thumbnail

Kai Uwe Broulik noreply at phabricator.kde.org
Thu Jan 17 14:14:03 GMT 2019


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoids loading huge screenshots just to show them in a tiny thumbnail.
  It's using `GridView.cellWidth` instead of `width` to avoid reloading the image as the layouting is done. Everytime `sourceSize` changes, the image is reloaded.

TEST PLAN
  Saves like 10 MB in both KCMS for me
  Verified that the Images are only loaded once upon opening the KCM
  Still looks ok, albeit slightly blurrier, as before `smooth` wasn't set on resizing and now it's done in image reader or so.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18322

AFFECTED FILES
  kcms/ksplash/package/contents/ui/main.qml
  kcms/lookandfeel/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190117/0d6e9800/attachment.html>


More information about the Plasma-devel mailing list