D18189: Fix ComboBox

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ComboBox.qml:207
>              implicitHeight: contentHeight
> -            model: controlRoot.popup.visible ? controlRoot.delegateModel : null
> +            model: controlRoot.model
> +            delegate: controlRoot.delegate

Breaking it down it's this one line that causes major regressions for me though I can't immediately see why.

Can you elaborate on what was broken and why you changed it?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18189

To: apol, #kirigami, mart
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/0dce8b06/attachment.html>