D18284: Set CombooBox QStyleOptionState == On rather than Sunken to match qwidgets

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  See the end of QComboBox::initStyleOption
  
    if (d->container && d->container->isVisible())
        option->state |= QStyle::State_On;
  
  The relevant breeze code reads:
  
    const bool hasFocus( enabled && ( state & (State_HasFocus |
  
  State_Sunken ) ) );
  
    const bool sunken( state & (State_On|State_Sunken) );
  
  So we still remain sunken in breeze, but we don't assume hasFocus, which
  gives the background an incorrect colour.
  
  BUG: 403153

TEST PLAN
  Ran testComboBox from Aleix
  Debug inside Breeze QStyle + reading Qt code

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18284

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190116/bf983e16/attachment.html>