D18182: Fix new file creation leading to dupe items on a fresh view

Fabian Vogt noreply at phabricator.kde.org
Tue Jan 15 08:50:38 GMT 2019


fvogt added inline comments.

INLINE COMMENTS

> foldermodel.cpp:152
>  
>      /*
>       * position dropped items at the desired target position

The comment refers to the first connect now, but is mostly aimed at the second. Maybe move it and add another one for the added connect call?

> foldermodel.cpp:154
>       * position dropped items at the desired target position
>       * delay this via queued connection, such that the row is available and can be mapped
>       * when we emit the move request

It doesn't use Qt::QueuedConnection explicitly - is the comment wrong or is it done implicitly?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D18182

To: hein, #plasma, McPain
Cc: fvogt, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190115/28e366f2/attachment.html>


More information about the Plasma-devel mailing list