D17154: Go back to SCSS

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> build_theme.sh:89-98
> +    COLOR_SCHEME="/usr/share/color-schemes/Breeze.colors"
> +  fi
> +else
> +  THEME_NAME="${COLOR_SCHEME}"
> +  if [ -f "/usr/share/color-schemes/${COLOR_SCHEME}.colors" ]; then
> +    COLOR_SCHEME="/usr/share/color-schemes/${COLOR_SCHEME}.colors"
> +  elif [ -f "${HOME}/.local/share/color-schemes/${COLOR_SCHEME}.colors" ]; then

We can't assume '/usr/share'/
Nor can we use the install prefix for where this is installed as that breaks distro packaging.

Breeze needs to export this location in it's installed .cmake file, then we should reference that.

I would also scrap all the stuff about ~/.local.

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D17154

To: gepardo, #plasma, jackg, #breeze, #vdg, ngraham, dirrukd, davidedmundson
Cc: lbeltrame, bshah, cgiboudeaux, davidedmundson, bcooksley, ngraham, jackg, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190112/d9014387/attachment.html>