D18182: Fix new file creation leading to dupe items on a fresh view
Eike Hein
noreply at phabricator.kde.org
Fri Jan 11 12:45:19 GMT 2019
hein created this revision.
hein added reviewers: Plasma, McPain.
Herald added a project: Plasma.
hein requested review of this revision.
REVISION SUMMARY
This was a regression caused by the code attempting to insert new items
at drop position, if available. `setSortMode` was being called in a slot
connected to the dir model's rowsInserted, but the Positioner has to be
initialized earlier as a proxy needs to handle
`sourceRowsAboutToBeInserted` as well.
Thanks to an investigation and patch by Oleg Solovyov in D17689 <https://phabricator.kde.org/D17689> for
helping to get to the bottom of this.
This is aimed at 5.12+.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.12
REVISION DETAIL
https://phabricator.kde.org/D18182
AFFECTED FILES
containments/desktop/plugins/folder/foldermodel.cpp
To: hein, #plasma, McPain
Cc: plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190111/8d8cdce4/attachment-0001.html>
More information about the Plasma-devel
mailing list