D17975: [Notifications] Add padding to notifications

[Root]

rooty added a comment.


  There is one small problem, with almost every version I've submitted so far.
  The padding above the icon and below the icon is the same (7 px with 1x scaling) if Noto Sans is used as the default font, which is basically perfect.
  
  However, if another font is used, the amount of padding below the icon changes (Cabin - 5 px, Lato - 3 px etc.).
  It's because I've been using bottomPart or the implicitHeight to make the notification "taller" so as to give the icon padding.
  
  Is there a way to give the icon itself padding? I've been using anchors but there's nothing I can think of to anchor it to? If I anchor it to the notification text in any way, I can add a margin, sure, but it gets //stretched out beyond belief//.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham, davidedmundson
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190110/a604638a/attachment.html>