D17975: [Notifications] Add padding to notifications

[Root]

rooty added a comment.


  In D17975#389695 <https://phabricator.kde.org/D17975#389695>, @broulik wrote:
  
  > We explicitly removed the padding in Plasma 5.9 to reduce popup sizes, this effectively reverts this decision…
  
  
  Sort of. This is basically what they looked like:
  F6537353: image.png <https://phabricator.kde.org/F6537353>
  And the result of D3560 <https://phabricator.kde.org/D3560> were a slew of custom themes that added the padding back. The main justification was:
  
  > Our notification popups are huge compared to other platforms
  
  and that's just not the case. At least not anymore:
  
  F6537359: image.png <https://phabricator.kde.org/F6537359>
  F6537361: image.png <https://phabricator.kde.org/F6537361>
  
  I grant that notifications without padding do save room. But it's really not that much room we're saving? Especially considering that a notification is something a user should be paying attention to.
  As far as text on the buttons is concerned, I'm confident we can make it work and that the labels need not be too short or too long, or in other words, that this is an issue completely separate from the padding issue.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: broulik, Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190109/7e11cf07/attachment.html>