D17975: [Notifications] Add padding to notifications

[Filip Fila]

filipf added a comment.


  In D17975#389584 <https://phabricator.kde.org/D17975#389584>, @ngraham wrote:
  
  > So what's going on here? Other themes add more padding? If so, I don't see how that's something we can possibly account for, and that shouldn't affect our ability to improve our own stuff.
  
  
  Yes, as you can see in the pics it doesn't just add extra padding but may also result in worse symmetry before.
  
  I'm simply saying we try to investigate if there might be a solution that improves our stuff, but doesn't regress other stuff.
  
  People do use other themes and they do notice when things get messed up. Example of the last time this happened:
  
  https://www.reddit.com/r/kde/comments/8rj3k7/wrong_media_player_icon_after_513_update/
  https://www.reddit.com/r/ManjaroLinux/comments/90drav/media_player_tray_icon_missing_kde/
  https://www.reddit.com/r/kde/comments/93thby/issues_with_the_new_media_player_icons/
  https://forum.manjaro.org/t/manjaro-18-kde-media-player-no-panel-icon-using-breath-theme-set/64010
  https://forum.manjaro.org/t/kde-breath-theme-missing-icons/51644
  https://forum.manjaro.org/t/kde-media-player-indicator-slot-empty/64199
  https://forum.manjaro.org/t/manjaro-18-kde-media-player-no-panel-icon-using-breath-theme-set/64010
  https://forum.manjaro.org/t/smplayer-missing-tray-icon-in-kde-when-playing-movie/58021
  
  I wouldn't want the attitude of "breaking other themes is unfortunate, but.." becoming a pattern because openness to customization is our main selling point.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: Codezela, abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190109/c228b998/attachment-0001.html>