D17975: [Notifications] Add padding to notifications

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> hein wrote in NotificationItem.qml:33
> Adding 1.75 pixels is just too arbitrary (and not an even number, and not scaled by device pixel ratio).

Much better.

Only part I don't understand, then ship it! from me.

Assuming there's no icon

For multiline

- 1 small space above 1 small space under.

For one line we effectively get:

- 0 margin on top, 0.5 under

Why the 0.5? Surely that would be inconsistent?

(In all your examples the icon is bigger so we don't see it)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: abetts, filipf, davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190108/4dcfac24/attachment.html>