D17975: [WIP, Notifications] Add padding to notifications

Root noreply at phabricator.kde.org
Tue Jan 8 01:31:49 GMT 2019


rooty added a comment.


  I removed "0.75 * units.smallSpacing" because it's not an integer - the result is that the margins are slightly uneven, but considering they weren't ever entirely even, and the difference between the margins gets more pronounced with increasing font size (and scaling factor), but isn't noticeable, maybe it's a nonissue?
  
  That being said, I've also added a line that raises the notification contents by units.smallSpacing if there is more than one line of text, to make the margins more even. 
  Before: 
  F6533113: before.png <https://phabricator.kde.org/F6533113>
  After: 
  F6533115: after.png <https://phabricator.kde.org/F6533115>

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190108/aa7cdac5/attachment-0001.html>


More information about the Plasma-devel mailing list