D18018: [Digital Clock] Add ability to change first day of week

[Chris Holland]

Zren added a comment.


  In D18018#387920 <https://phabricator.kde.org/D18018#387920>, @davidedmundson wrote:
  
  > Is there a use case for having it configurable inside the plasmoid separately from configuring it system wide?
  
  
  https://bugs.kde.org/show_bug.cgi?id=390330#c5
  
  > Just change the locale to Egypt [مصر - العربية (ar_EG)] (the user prefers en_US) and many countries in the region and the start of the week will be Saturday.
  >  Changing the local from systemsettings will results in too many changes across KDE that I do not want. Since I can no longer change every minor detail in the Regional settings I had to edit files directly to achieve what I want.
  
  F6531531: image.png <https://phabricator.kde.org/F6531531>
  
  I don't believe anyone asked if he changed the "time locale" to ar_EG while leaving the rest at en_US. However testing with `LC_TIME="ar_EG.UTF-8"` shows that it would change the hour/month/year into arabic, which probably wasn't desired.
  
    LC_TIME="ar_EG.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock
    LANGUAGE="ar_EG:ar" LANG="ar_EG.UTF-8" LC_TIME="ar_EG.UTF-8" plasmoidviewer -a org.kde.plasma.digitalclock
  
  The ability to customize Qt's `en_US` locale's `firstDayOfWeek` system wide would be nice. It would be difficult to do though I assume? We'd essentially need to create a new locale right? Thus the simplicity of making just the widget configurable.
  
  Right now with the patch, the `firstDayOfWeek` in the widget would be different than the Qt Widget calendar in "Adjust Date and Time...". So we might get new bug reports of the user annoyed that the feature only affects the digitalclock widget.
  
  It also only affecting the current screen, as they'd need to change it on every screen's panel, but that is also a gripe with the "Show Date" toggle as well.

INLINE COMMENTS

> pino wrote in configCalendar.qml:68
> this needs a context (using i18nc), otherwise translators have no idea what "Default" means

Is this informative enough? `i18nc("locale's default day of week", "Default")`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D18018

To: Zren, #plasma
Cc: abetts, pino, davidedmundson, ngraham, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190108/7fdb526a/attachment.html>