D17975: [WIP, Notifications] Add padding to notifications

[Root]

rooty added a comment.


  @davidedmundson Is there anything I can put in the code to get the icons to scale properly? this is a screenshot of master (not this patch):
  
  F6529598: image.png <https://phabricator.kde.org/F6529598>
  
  I've tried multiplying units.iconSizes.large by the scaling factor, and that works, but that's as ballpark a solution as they come...

INLINE COMMENTS

> davidedmundson wrote in NotificationItem.qml:175
> > Is there any way around this? Because if it's not 0.75 then it's shifted too far down (uneven padding)
> 
> If that's the case, adjust the other side, even adjust the window if you need to.

Nate's right though, I should abandon the idea of totally even padding because it'll never hold up as you change fonts or scaling... then again it doesn't have to be perfect, right? Just close enough?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D17975

To: rooty, #vdg, #plasma, ngraham
Cc: davidedmundson, hein, ndavis, plasma-devel, kvanton, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190106/20fc57bf/attachment.html>