D17961: Fix static Kirigami (about page etc)
Dan Leinir Turthra Jensen
noreply at phabricator.kde.org
Fri Jan 4 13:06:42 GMT 2019
leinir created this revision.
leinir added reviewers: Kirigami, apol, mart.
leinir added a project: Kirigami.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.
REVISION SUMMARY
Without this patch, if you tried to use the AboutPage component in a static Kirigami app, the QML engine would complain that the file was missing (of course). Further, once that was fixed, the function i18n also does not exist unless you add it, and since everything else in Kirigami uses qsTr, it seems to make sense to use that in AboutPage and UrlButton as well.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D17961
AFFECTED FILES
kirigami.qrc.in
src/controls/AboutPage.qml
src/controls/UrlButton.qml
To: leinir, #kirigami, apol, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190104/ad6eded7/attachment.html>
More information about the Plasma-devel
mailing list