D17930: Be less memory-hungry when compiling the Keyboard KCM's gemoetry parser
Nathaniel Graham
noreply at phabricator.kde.org
Wed Jan 2 20:56:19 GMT 2019
ngraham created this revision.
ngraham added reviewers: Plasma, hein, davidedmundson, bshah.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
The current recursion depth of 512 is rather large and causes out-of-memory errors on even fairly beefy machines.
This patch reduces the recursion limit to 64, which allows plasma-desktop to be compiled on a test of a simulated very low-end machine in a VM: 2 processors with 2 GB RAM.
BUG: 362946
FIXED-IN: 5.12.8
TEST PLAN
Compile plasma-desktop on the above-mentioned VM without first disabling this feature ot not building the keyboard KCM. It works!
REPOSITORY
R119 Plasma Desktop
BRANCH
geometry-parser-compilation-fix (branched from Plasma/5.12)
REVISION DETAIL
https://phabricator.kde.org/D17930
AFFECTED FILES
kcms/keyboard/CMakeLists.txt
To: ngraham, #plasma, hein, davidedmundson, bshah
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190102/4657d3fe/attachment-0001.html>
More information about the Plasma-devel
mailing list