D12278: WIP: [Colors KCM] Port to new design

[Nathaniel Graham]

ngraham added a comment.


  In D12278#384981 <https://phabricator.kde.org/D12278#384981>, @GB_2 wrote:
  
  > > This removes the "Apply to non-Qt applications checkbox" which isn't something one should uncheck.
  >
  > I disagree. I even think it should be disabled by default, because it causes issues in GTK 2 apps such as this: https://i.stack.imgur.com/jpeYm.jpg
  >  I think it is not needed, because the GTK 2 theme already defines which colors are used and that should not be overwritten because of the issues.
  
  
  If we remove the checkbox for this, then it needs to be off by default so people stop hitting https://bugs.kde.org/show_bug.cgi?id=355540. If we remove the checkbox and don't include a way to turn off the setting, then there is no way to recover from that bug.
  
  Alternatively I guess we could fix the bug. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12278

To: broulik, #plasma, #vdg
Cc: GB_2, nicolasfella, mart, abetts, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190102/c69e68ea/attachment-0001.html>