D17218: Fix removing first item in languages list
Eike Hein
noreply at phabricator.kde.org
Wed Jan 2 08:28:43 GMT 2019
hein added inline comments.
INLINE COMMENTS
> davidedmundson wrote in translationsmodel.cpp:216
> Changing from index < 1 to checking count makes sense, but I would still check
>
> if (index < 0) {return;}
>
> in addition to the count to catch out-of-sync erorrs. I think then you wouldn't need to complicate the QML side.
I'll add the check (it's nice for sanity anyways), but the changes to the QML are actually unrelated - it's simply the delegate crashing in the Qt Quick runtime when the expression bound to `enabled` is re-evaluated while the delegate is being destroyed. I didn't find any better fix.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D17218
To: hein, #plasma, davidedmundson, broulik
Cc: plasma-devel, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190102/980c4e4d/attachment.html>
More information about the Plasma-devel
mailing list