D19230: [Digital Clock] Replace 12/24hr tri-state checkbox in config UI with combobox

[Noah Davis]

ndavis added a comment.


  In D19230#422088 <https://phabricator.kde.org/D19230#422088>, @ngraham wrote:
  
  > We could, but is that really necessary? In general we try to avoid having UI elements dynamically show and hide themselves outside of the narrowly-defined exception of when a UI element is inapplicable to the currently active hardware. That condition doesn't apply here, so what we would do instead is enable and disable the button, which I think would be a bit weird.
  
  
  Fair point. I just think it's not necessary to show the button if you're not using the setting that uses the settings behind the button.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  replace-tristate-checkbox-with-combobox (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19230

To: ngraham, #plasma, Zren, #vdg, davidedmundson, ndavis
Cc: totte, ndavis, abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190228/26a74866/attachment.html>