D19392: shannon entropy to guess monochrome icon

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> cfeck wrote in desktopicon.cpp:545
> You are caching the result per size, but the initial decision depends on the actual icon image, right? Is it possible that the first icon examined is colorful, but the rest is not, or vice versa? If yes, would it make sense to examine a few icons (maybe three) before a decision is made?

the actual icon image can vary depending on size, usually themes have multiple images per icon separed by those "standard sizes" i'm checking against, so it's possible that like the 16 trough 24 sizes are monochrome and beyond are colored for instance (is often the case in breeze icons)

> cfeck wrote in desktopicon.h:108
> `QHash<int, bool>` is just a `QSet<int>`.

not really, because with a qset i could only cache those that i know are monochrome but i can't tell the difference between "i didn't test yet" and "i tested and isn't monochrome"

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19392

To: mart, #kirigami
Cc: cfeck, davidedmundson, plasma-devel, domson, dkardarakos, apol, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190228/cafd2cc7/attachment-0001.html>