D19280: [TaskManager] Modernize and reorganize configuration settings

Björn Feber noreply at phabricator.kde.org
Sun Feb 24 20:43:38 GMT 2019


GB_2 added a comment.


  Almost perfect!

INLINE COMMENTS

> ConfigBehavior.qml:64
> +            id: onlyGroupWhenFull
> +            text: i18n("Only when the Task Manager is full")
> +            enabled: groupingStrategy.currentIndex > 0 && groupPopups.checked

"Task Manager" should be lowercase and a better text would be "Only group when the task manager is full".
I'd also switch the position with the above checkbox.

> ConfigBehavior.qml:115
> +            id: showOnlyCurrentScreen
> +            Kirigami.FormData.label: i18n("Filters:")
> +            text: i18n("Show only tasks from the current screen")

Better: "Filter:"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19280

To: filipf, #plasma, #vdg, ngraham, rooty
Cc: GB_2, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190224/ee35f1ea/attachment.html>


More information about the Plasma-devel mailing list