D19257: [Task Manager] Fix virtual desktops subtext on task tooltip
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Sun Feb 24 00:00:14 GMT 2019
apol added inline comments.
INLINE COMMENTS
> Task.qml:370
> toolTipDelegate.virtualDesktopParent = Qt.binding(function() {
> - return model.VirtualDesktop != undefined ? model.VirtualDesktop : 0;
> + return (model.VirtualDesktops != undefined || model.VirtualDesktops.length == 0) ? model.VirtualDesktops : [0];
> });
I think you should be using !== and === on these comparisons as you don't expect casts.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D19257
To: hein, #plasma
Cc: apol, Fuchs, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190224/9098989a/attachment.html>
More information about the Plasma-devel
mailing list