D19226: [about-distro] let distributions choose VERSION_ID or VERSION

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  by default we display VERSION_ID because it is the pure numeric
  representation while VERSION may contain all sorts of clutter information
  that overloads the KCM and possibly makes the KCM look ugly.
  but, VERSION is technically meant for displaying to the user, so there
  is a reason why a distribution may choose to display that instead of the
  ID.
  
  to give them control over this there's now a bool config entry
  UseOSReleaseVersion which defaults to false, when set to true the KCM
  will use the VERSION instead of VERSION_ID.

TEST PLAN
  - VERSION and VERSION_ID are different
  - config value not set
  - kcm uses VERSION_ID
  - config value set to true
  - kcm uses VERSION

REPOSITORY
  R102 KInfoCenter

BRANCH
  osrversion

REVISION DETAIL
  https://phabricator.kde.org/D19226

AFFECTED FILES
  Modules/about-distro/example/kcm-about-distrorc.ex
  Modules/about-distro/src/Module.cpp

To: sitter, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190222/466781bc/attachment.html>