D19011: Thunderbolt KCM and KDED module

[Nathaniel Graham]

ngraham added a comment.


  Thanks, much better! Just a few more UI nitpicks. And one more thing: What does "Stored" mean in this context? As a non-Thunderbolt expert, I don't know what this means, and I suspect most users wouln't, either.

INLINE COMMENTS

> DeviceList.qml:41
> +            id: enableBox
> +            text: i18n("Allow Thunderbolt devices")
> +

"Enable" might be a better word than "Allow" in this string.

> DeviceView.qml:50
> +        RowLayout {
> +            ToolButton {
> +                icon.name: "draw-arrow-back"

Can we give this a label or make it a `Button` instead? Many users have difficulty recognizing label-less toolbuttons floating inside the page as clickable buttons.

> DeviceView.qml:150
> +            }
> +            Button {
> +                id: forgetBtn

I'd recommend that we center this horizontally on the page.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, broulik, ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190222/baf7d227/attachment.html>