D19077: Redesign the theme preview window
Nathaniel Graham
noreply at phabricator.kde.org
Thu Feb 21 23:05:08 GMT 2019
ngraham added a comment.
This introduces a new warning:
WARNING: viewBackgroundColor is deprecated, use backgroundColor with colorSet: Theme.View instead
+1 on removing the italic styling. I also think bolding the title is unnecessary too while it's using its maximum size (level 1). Bolding it only seems necessary when it's closer to the size of the text below it.
I still don't like how the ColumnLayout of information causes the bottom-most items to get cut off with the default System Settings window height. I think we could consolidate some of the information, like moving the license onto one of the other lines.
Here's basically how it would look:
F6628909: Screenshot_20190221_160448.png <https://phabricator.kde.org/F6628909>
REPOSITORY
R123 SDDM Configuration Panel (KCM)
REVISION DETAIL
https://phabricator.kde.org/D19077
To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/048244e7/attachment.html>
More information about the Plasma-devel
mailing list