D18716: Add an ActionTextField component

[Marco Martin]

mart added a comment.


  it''s aaaalmost perfect,
  just a little point on the icon loading, then is good to go

INLINE COMMENTS

> MultipleColumnsGallery.qml:61
>          Controls.Label {
> -            anchors.horizontalCenter: parent.horizontalCenter
> +            Layout.alignment: Qt.AlignHCenter
>              text: "Page implicitWidth: " + page.implicitWidth

unrelated change, separate commit?

> ActionTextField.qml:103
> +                width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +                source: modelData.iconName
> +                visible: modelData.visible

icon.name, so will work also with qqc2 actions

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : modelData.icon.source

> ActionTextField.qml:124
> +                width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +                source: modelData.iconName
> +                visible: modelData.visible

icon.name

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : modelData.icon.source

> ognarb wrote in kirigamiplugin.cpp:181
> @mart Should I use 2.6 or 2.7? I didn't find any information about that version I should use.

2.7

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/abc95fc0/attachment-0001.html>