D19203: ColumnView and partial C++ refactor of PageRow

Marco Martin noreply at phabricator.kde.org
Thu Feb 21 15:12:43 GMT 2019


mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  ColumnView is a container component which encapsulates most of the logic from PageRow
  (minus the instantiation of components from paths which stays in PageRow)
  with that, new features are possible, such as having expanded pages which aren't the last one 
  or inserting/removing arbitrary pages, to make it behave not like a stack.
  This solves also some glitches as ListView is quite buggy.

TEST PLAN
  tested with Kirigmai Gallery and some other apps such as the new PureMaps which needs some of 
  the new features.
  By normal usage, no visual change should occur.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/columnsView

REVISION DETAIL
  https://phabricator.kde.org/D19203

AFFECTED FILES
  src/CMakeLists.txt
  src/columnview.cpp
  src/columnview.h
  src/columnview_p.h
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/private/ActionButton.qml
  src/kirigamiplugin.cpp

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190221/27489f47/attachment.html>


More information about the Plasma-devel mailing list