D19179: Use PointingHand when hovering links in Label

Filip Fila noreply at phabricator.kde.org
Wed Feb 20 22:02:10 GMT 2019


filipf added a comment.


  In D19179#416235 <https://phabricator.kde.org/D19179#416235>, @leinir wrote:
  
  > In D19179#416222 <https://phabricator.kde.org/D19179#416222>, @filipf wrote:
  >
  > > I had to use I think identical code precisely for this use case recently, however it resulted in increased spacing in ColumnLayout (right after MouseArea). Now I'm just a novice tinkerer so apologies if the question is stupid, but could it cause similar issues if implemented here?
  >
  >
  > Since the MouseArea is contained within the Label, it should have no effect at all on anything outside it (if i understand your "right after MouseArea" correctly, the MouseArea was a child of the layout, not a child of an item inside the layout? if not, then certainly that is an oddity and i'd greatly appreciate seeing that, though perhaps not in this comment thread ;) )
  
  
  It was my mistake by not containing it within the label. Thanks for this fix, as you see in the mentioned diff, I will make good use of it :)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190220/e158cd88/attachment-0001.html>


More information about the Plasma-devel mailing list