D19077: Fix long labels not being wrapped

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Neato, getting there...

INLINE COMMENTS

> main.qml:18
> +import QtQuick 2.4
> +import QtQuick.Layouts 1.4
> +import QtQuick.Controls 2.4 

Version does not exist, use version 1.12 instead

> main.qml:21
> +import org.kde.kirigami 2.4 as Kirigami
> +import QtGraphicalEffects 1.4
>  

Use version 1.0 instead or else it will cause a crash:

  file:///usr/share/sddm-kcm/main.qml:21:1: module "QtGraphicalEffects" version 1.4 is not installed 
       import QtGraphicalEffects 1.4 
       ^
  KCrash: crashing... crashRecursionCounter = 2
  KCrash: Application Name = systemsettings5 path = /usr/bin pid = 4958
  KCrash: Arguments: /usr/bin/systemsettings5 
  KCrash: Attempting to start /usr/lib/x86_64-linux-gnu/libexec/drkonqi from kdeinit
  sock_file=/run/user/1000/kdeinit5__0

> main.qml:80
> +            font.weight: Font.Bold
> +            Layout.maximumWidth: column.width
> +            elide: Text.ElideRight

Instead, use `Layout.fillWidth: true` for all of these since there's nothing to the right of them

> main.qml:122
> +        
> +            MouseArea {
> +                anchors.fill: url

This hack will not be needed if and when D19179 <https://phabricator.kde.org/D19179> lands, BTW.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190220/41fcfcd6/attachment-0001.html>