D19176: [weather] envcan: Fix typo in lowercase icon lookup string

Chris Holland noreply at phabricator.kde.org
Tue Feb 19 23:43:44 GMT 2019


Zren created this revision.
Zren added reviewers: Plasma, kossebau.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Zren requested review of this revision.

REVISION SUMMARY
  The capital `S` breaks the icon match.
  
  It was broken in Plasma 5.6 <https://github.com/KDE/plasma-workspace/blob/Plasma/5.6/dataengines/weather/ions/envcan/ion_envcan.cpp#L290> => Plasma 5.7 <https://github.com/KDE/plasma-workspace/blob/Plasma/5.7/dataengines/weather/ions/envcan/ion_envcan.cpp#L292>, so I guess I'll merge 5.12 => 5.14 => 5.15 => master, assuming we still need to backport to 5.14 for Debian?  
  https://github.com/KDE/plasma-workspace/blob/Plasma/5.12/dataengines/weather/ions/envcan/ion_envcan.cpp#L294
  
  Do I bother putting `FIXED-IN: 5.15.2` if there's no bug report?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19176

AFFECTED FILES
  dataengines/weather/ions/envcan/ion_envcan.cpp

To: Zren, #plasma, kossebau
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190219/322bba5d/attachment.html>


More information about the Plasma-devel mailing list