D19044: [InlineMessage] Do not draw shadows around the message

[Marco Martin]

mart added a comment.


  In D19044#414530 <https://phabricator.kde.org/D19044#414530>, @ngraham wrote:
  
  > In D19044#414479 <https://phabricator.kde.org/D19044#414479>, @mart wrote:
  >
  > > -1
  > >  this has to be done at most for the desktop style and the desktop style only
  >
  >
  > Can you explain a bit more? I don't understand the technical reason for why you think we should do this in the QQC2 style only. If anything, wouldn't it make sense to not have the shadow here and only add it in the QQC2 style if we did want it there (which we don't)?
  
  
  nope, not in the qqc2 style, but in the kirigami style (yes, kirigami has styles, which must have the same name as the corresponding qqc2 styles)
  
  I would like to maintain the shadow at least with material.
  this means splitting inlinemessage in a copy in templates/ and a copy in controls/ which just instantiates the one in templates and implements its background item.
  
  then in styles/ the desktop one will have a different background with no shadow (or the base version may have a shadow then there would be a copy in material which it would, don't care)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: ndavis, mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190219/3f247f15/attachment.html>