D18646: [Colors KCM] Add search and filter

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  LGTM aside from the minor naming nitpick.

INLINE COMMENTS

> filterproxymodel.cpp:31
> +
> +void FilterProxyModel::setSourceModelProxy(QAbstractItemModel *sourceModel)
> +{

Why did you call this `setSourceModelProxy`? `QSortFilterModel::setSourceModel` is virtual, you could do the emit in a reimpl?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18646

To: broulik, #plasma, #vdg, hein
Cc: hein, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20190219/37c09f79/attachment.html>